Page MenuHomePhabricator

Wrong call to applyPatch in MysqlUpdater
Closed, ResolvedPublic

Description

Author: sels

Description:
i try to upgrade to 1.17.
update.php is complaing about a missing applyPatch function.

changing

$this->db->applyPatch( $patchFile );

to

$this->applyPatch( $patchFile );

in includes/installer/MysqlUpdater.php on line 194 will fix this issue.


Version: 1.17.x
Severity: normal

Details

Reference
bz26540

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:23 PM
bzimport set Reference to bz26540.
bzimport added a subscriber: Unknown Object (MLST).

sels wrote:

its still db-> in 79485 can you add it to branch http://svn.wikimedia.org/svnroot/mediawiki/branches/REL1_17/phase3/includes/installer/MysqlUpdater.php or did you change it that it works with db?

(In reply to comment #2)

its still db-> in 79485 can you add it to branch
http://svn.wikimedia.org/svnroot/mediawiki/branches/REL1_17/phase3/includes/installer/MysqlUpdater.php
or did you change it that it works with db?

The revision hasn't been merged to the branch yet. I merged another batch recently and we've currently got just one reviewed revision ready for backporting (the fix for this bug), so I'll wait until there are a few more in the queue (or other existing revisions in the queue get reviewed) before I backport another batch. This'll probably happen on Tuesday or Wednesday.

Reclosing as FIXED because that's what we do once bugs are fixed in trunk.