Page MenuHomePhabricator

Cannot unwatch a thread without javascript unless going to the thread page
Open, LowPublic

Description

Author: Nx.devnull

Description:
If you have javascript disabled, clicking on the unwatch link in the thread header doesn't work. It just takes you to a default thread view without unwatching the thread.

I'm attaching a modified pages/ThreadWatchView.php that fixes this.


Version: unspecified
Severity: minor

Details

Reference
bz26562

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:11 PM
bzimport set Reference to bz26562.
bzimport added a subscriber: Unknown Object (MLST).

Nx.devnull wrote:

modified pages/ThreadWatchView.php

Calls $this->thread->root()->watch() or $this->thread->root()->unwatch() based on value of $request->getVal( 'action' ) in the constructor.

Attached:

+keyword

Going to the Thread: page, accessible from "permanent link", gives you access to the normal watch/unwatch buttons.

sumanah wrote:

Thanks for keywording, Nemo_bis, and thanks for the patch, Nikola! It'd be great if you'd put future patches into Git: https://www.mediawiki.org/wiki/Git/Tutorial That'll get them reviewed faster.

Nikola:
You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier for us to review it quickly.
Thanks again!

Jdforrester-WMF lowered the priority of this task from Low to Lowest.Aug 4 2016, 11:35 PM
Jdforrester-WMF subscribed.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Low.Aug 5 2016, 7:37 AM