Page MenuHomePhabricator

OpenStackManager extension needs proper security checks
Closed, ResolvedPublic

Description

There's a few rudimentary security checks in place now, but the extension needs to ensure users have proper rights to access certain special pages.

Specifically, Special:NovaProject, and Special:NovaDomain should ensure a user is an admin, or have some special right.

Additionally, the current security checks aren't likely done in the normal MediaWiki style. This should be corrected.


Version: unspecified
Severity: major

Details

Reference
bz26576

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:12 PM
bzimport set Reference to bz26576.

Accidentally marked this as resolved.

More specific implementation:

Special:NovaProject should be limited to wiki admins

Special:NovaDomain, Special:NovaHost, and Special:NovaAddress should be limited to users with the 'netadmins' role.

Special:NovaInstance should be limited to users with the 'sysadmin' role.

Roles are pulled from LDAP, and are accessible via OpenStackNovaUser->inRole(), or OpenStackNovaUser->getRoles()