Page MenuHomePhabricator
Create Task
Maniphest T28602

Corrupt link to version when viewing a diff
Closed, ResolvedPublic
Actions

Description

Author: a.d.bergi

Description:
Since Bug 25289 went live, the diff view is loaded per JavaScript. Before that happens, the user gets a link to the diff. Without JS he has to use it. Not friendly, but OK.
Today at [[:de:WP:AA]] we got a request that this link doesn't work. The oldid parameter is missing, so you will have to follow the link above to see the version. For example, in the denoted URL above the link is just http://de.wikipedia.org/w/index.php?title=...&oldid= instead of http://de.wikipedia.org/w/index.php?title=...&oldid=83430288

Please fix it fast.

Version: unspecified
Severity: critical
URL: http://de.wikipedia.org/w/index.php?title=S%C3%BCdtiroler_Apfel_g.g.A.&diff=prev&oldid=83430288

Details

Reference
bz26602

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:14 PM
• bzimport added a project: MediaWiki-extensions-FlaggedRevs.
• bzimport set Reference to bz26602.
• bzimport created this task.Jan 6 2011, 9:29 AM
• RobLa-WMF added a comment.Jan 6 2011, 5:31 PM

Yup, I see it. We'll take a look at it.

aaron added a comment.Jan 8 2011, 8:18 PM

r78214 didn't fully merge r78213 for some reason. Was that done manually or something?

aaron added a comment.Jan 21 2011, 7:48 AM

(In reply to comment #2)

r78214 didn't fully merge r78213 for some reason. Was that done manually or
something?

BTW, this is the sole cause (if that wasn't clear).

• RobLa-WMF added a comment.Feb 10 2011, 10:18 PM

Priyanka, we think this was dealt with, but could you confirm that this is fixed for 1.17?

• bzimport added a comment.Feb 11 2011, 9:40 PM

pdhanda wrote:

I verified this on http://prototype.wikimedia.org/release-en and on the recently deployed he.wikisource
http://he.wikisource.org/w/index.php?title=%D7%94%D7%A7%D7%95%D7%A8%D7%90%D7%9F_%D7%91%D7%AA%D7%A8%D7%92%D7%95%D7%9D_%D7%94%D7%92%D7%95%D7%9C%D7%A9%D7%99%D7%9D_-_%D7%A4%D7%A8%D7%A9%D7%AA_%D7%94%D7%A4%D7%AA%D7%99%D7%97%D7%94&action=historysubmit&diff=335215&oldid=278148
Seems to work.
-p

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL