Page MenuHomePhabricator

WikiEditor: Icons for dialogs in wrong order
Closed, DeclinedPublic

Description

In MW 1.17 the icons for dialogs in the toolbar are displayed in wrong order, the reference icon appears on discussion pages as well. See URL.
It should be: link - file - signature
It is: file - signature - link - reference
This is obvious due to r74114.


Version: unspecified
Severity: minor
URL: http://prototype.wikimedia.org/d-en/index.php?title=Wikipedia:Article_development&action=edit

Details

Reference
bz26621

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:15 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz26621.
bzimport added a subscriber: Unknown Object (MLST).

Fixed the reference button to no longer appear in talk namespaces in r79842. I asked Trevor to comment on the order issue.

I think the order should match user expectations (justification for change the order back to how it was), but also take into consideration information we have about how often the tools are used (need to dig up click tracking stats) because we know that users most commonly look at the icons in order, looking for what they want. Anyone have the click tracking stats?

I talked to Parul about this, and the order for the discussion page should be (from left to right): link, file, signature. This is based in both qualitative and quantitative user behavior observation.

I also looked into why this is occuring, and as Roan mentioned, it's because we now use the API to remove the 2 link tools (internal and external) and add the link dialog tool - which results in the link tool being at the very end.

There's not elegant way to control order or placement right now - I'm open to ideas.

What about removing file, signature and redirect in ext.wikiEditor.dialogs.js and adding them again in the right place? The config object should be stored somewhere for this purpose (there is already a FIXME in ext.wikiEditor.toolbar.js for this), but that shouldn't be too hard.

@Aklapper can this task be declined since the issue was fixed except from now it is in order signature, link and file. And there hasen't been any discussion since 2011 on this bug.