Page MenuHomePhabricator

Few help field hint and the related warning messages are ambiguous
Closed, ResolvedPublic

Description

Author: nadeejw

Description:
Database name hyphens

Steps to reproduce:

  1. Navigate upto the 'Connect to database' page.
  2. Input invalid 'Database name'. (e.g. my_wiki#)
  3. Click on the 'Continue' button.
  4. Click on the 'help' field hint for the 'Database name'.
  5. Compare the warning message and the help field hint.

Note : Same behavior for 'Database table prefix'. (refer the screenshots)

Actual results:
Warning message - Invalid database name "my_wiki#". Use only ASCII letters (a-z, A-Z), numbers (0-9), underscores (_) and hyphens (-).

Help field hint - Choose a name that identifies your wiki. It should not contain spaces or hyphens. ......

Note : Currently system accepts database names with hyphens.

Expected results:
Either one of the message should be changed.


Version: 1.18.x
Severity: trivial
OS: Windows XP
Platform: PC

Attached:

hyphens_db_name.JPG (934×1 px, 148 KB)

Details

Reference
bz26685

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:19 PM
bzimport set Reference to bz26685.
bzimport added a subscriber: Unknown Object (MLST).

nadeejw wrote:

Database prefix hyphens

Attached:

hyphens_db_prefix.JPG (934×1 px, 117 KB)

DB name *can* have hyphens (see r79767 / bug 25969). Fixed message in r80081 to reflect this.

nadeejw wrote:

Retest passed for the 'Database name' field.
Retest failed for the 'Database table prefix' field.

Fixed it for prefixes in r80202.