Page MenuHomePhabricator

Success message broken
Closed, ResolvedPublic

Description

After successfully uploading multiple files (SVN r79596) the message is a literal (I put a blank in front of the ";" to make sure it is not converted, original output is without the blank).

&lt ;successfulupload&gt ;

Some of the messages had been updated for an earlier use of multiupload, so this bug may depend on using a database-derived message rather than the native system message.

I rate this bug major, because it is the main success message and is irritating users, thinking something went wrong.


Version: unspecified
Severity: major

Details

Reference
bz26744

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:23 PM
bzimport set Reference to bz26744.
bzimport added a subscriber: Unknown Object (MLST).

travis wrote:

It works for me.

successfulupload is defined in all of the messages files in languages/messages, it's not a extension specific message.

What language did you experience this in?

I am working on the same wiki, you can upload but the heading message is still broken. It seems that the system message "succesfulupload" is not defined so it puts <succesfulupload> from the php call wfMsgHtml( 'successfulupload' ) which becomes "&lt ;successfulupload&gt ;" (without spaces of course)

Should it not be "upload-success-msg" instead? This is defined.

travis wrote:

Which Mediawiki version are you working with, and in what language?

The message is defined as successfulupload in MessagesEn.php:

egrep successfulupload languages/messages/MessagesEn.php

'successfulupload' => 'Successful upload',

travis wrote:

This definition is in Mediawiki 1.16.0.

travis wrote:

Looks like this was removed with this revision change:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/languages/messages/MessagesEn.php?r1=70028&r2=70138&pathrev=79596

Unfortunately, this extension is written for 1.16, it hasn't been tested on 1.18. Since most people are using this version, I think it makes sense to keep it as is.

To fix this bug on your own wiki, you can create a Mediawiki:successfulupload article with the contents

Successful upload

Just a note: this means the extension does not work on current wikipedia. I rather believe that most sites follow wikipedia

http://en.wikipedia.org/wiki/MediaWiki:Successful_upload

Current correct message is: upload-success-subj