No reason to use smush-it. just find the proper imagemagick commands and apply them, or create new imagemagick commands that do the same.

We don't want to have to depend on yahoo.com for something like this.

Fair enough. Will google for those imagemagick commands.

Not sure if you could make this into an extension (for those who did want to use it...)

MediaWiki generally prefers to accept input files in their exact original format, then create derivative files optimized for output (convert to web-friendly sizes & formats, strip giant EXIF thumbnails, etc).

To actually modify the original file on upload, you'd probably want to do it pretty early in the upload process, so you're not worrying about for instance accidentally changing the file after a SHA-1 checksum has been generated.

The 'UploadVerifyFile' hook might actually be an ok place to rig something up, though it might not be ideal. (Disclaimer: I haven't tried it.)

Bryan.TongMinh wrote:

(In reply to comment #4)

The 'UploadVerifyFile' hook might actually be an ok place to rig something up,
though it might not be ideal. (Disclaimer: I haven't tried it.)

It needs a new hook I think. Something that is called just after fetchFile().

Assigning to subfader@gmail.com so he can respond with whatever his findings are.

Not much I found out. Except strip there are no other imagemagick options you can easily use on the fly without checking the image with a script.

The main advantage of the smush.it API is, that you don't to care about all that (nor in the future). The image you receive is losslessly optimized to the max while keeping metadata for JPEGs.

Thumbs generated by with imagemagick don't save much filesize when you smush them. Except PNG thumbs of course, but that's the compromize for having it resized on the fly.

But I talk about saving webspace and traffic for the originally uploaded images. Thus I can understand Brion's pov having the originals untouched. But not every wiki using MediaWiki is Wikipedia... (I love that argument).

So, I'd love to have an option to smuch images on upload, but can understand if no dev wants to implent it since most devs only code what is good for WP.

This would probably be much better as a extension that hooked into MW, re product-ing and component-ing as such.

I gave up using Smush.it cos it's not worth the effort the manual way.

Also I came across a few bad results (like 1 in 100) where color layers (dunno what they're called) were removed in PNGs.

Also I agree it may be better as extension.

Someone feel free to close this as WONTFIX.