Page MenuHomePhabricator

UI issues in Wiki editor in Internet Explorer
Closed, DeclinedPublic

Description

Author: nadeejw

Description:
Screen shot from IE7

Steps to reproduce

  1. Open a wiki page in edit mode(IE7 or IE8).
  2. Observe the left side of the wiki toolbar and the 'Heading; dropdown.

(Refer the screen shot)


Version: unspecified
Severity: minor

Attached:

UI_Issues_IE7.JPG (934×1 px, 140 KB)

Details

Reference
bz26828

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:16 PM
bzimport set Reference to bz26828.
bzimport added a subscriber: Unknown Object (MLST).

Does not seem to affect IE 8 on Windows 7; prototype link above & my local test appear fine. I have no IE 7 handy to test.

(In reply to comment #2)

Does not seem to affect IE 8 on Windows 7; prototype link above & my local test
appear fine. I have no IE 7 handy to test.

You can put IE8 in IE7 compat mode and even into IE7 mode.

Testing with IE7 on Windows XP...

The lefthand border on the edit area flickers on and off (sometimes it is missing as in the screenshot). The other spacing errors appear to have been eliminated in the meantime.

I think the culprit is here in ext.wikiEditor.css:

/* This ID (#wpTextbox1) could change in MediaWiki */
.wikiEditor-ui textarea#wpTextbox1 {
border: none;
padding: 0;
margin: -1px; /* <--- bing bing bing */
line-height: 1.5em;
}

Removing that -1px margin fixes the problem for me. It was added in r54484, labeled as "Fixed IE problem (invisible toolbar controls) and also textarea fitting issues."

What specific issues does it help with, and do those need an alternate fix?

Change 124607 had a related patch set uploaded by TheDJ:
Cleanup borders of wikiEditor

https://gerrit.wikimedia.org/r/124607

I've removed that border now, but I see still see this problem. Now it's because of a border:0 definition. Basically, you apparently cannot mess with the default borders of a text area, without running into this problem. We could reset the border back to it's defaults only for IE7, but i think that's a bit over the top.

I'm saying wontfix. Not likely that we will deal with this small visual glitch after so many years, with IE7 having such a small browser share.