Page MenuHomePhabricator

OutputPage::addVaryHeader throws a warning
Closed, ResolvedPublic

Description

OutputPage::addVaryHeader throws a warning when the second parameter is null in array_unique in that method.


Version: 1.18.x
Severity: minor

Details

Reference
bz26861

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:19 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz26861.
bzimport added a subscriber: Unknown Object (MLST).

r80755 should clear it up; the null wasn't actually getting forced to an empty array, which it seems to prefer.

Though.... I notice down in getXVO it seems to want to append options for the X-Vary-Options sections as long as there's an array, even if it's empty, which is probably wrong.