Page MenuHomePhabricator

add width/height param to {{filepath:}}
Closed, ResolvedPublic

Description

In addition to r80381: Please add width/height param also to {{filepath:}}.

Thanks.


Version: 1.18.x
Severity: enhancement

Details

Reference
bz26870

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:19 PM
bzimport set Reference to bz26870.

So far we haven't had any named paremeters to a (core) magic word / parser function. So I'm holding back with any "width=" or "height=".

Implemented width in r80813.

One can now use any of the following:

{{fullurl:Example.svg}}
{{fullurl:Example.svg|nowiki}}
{{fullurl:Example.svg|nowiki|300}}
{{fullurl:Example.svg|300}}
{{fullurl:Example.svg|300|nowiki}}

(In reply to comment #1)

One can now use any of the following:
(...)

I obviously meant to say:

*{{filepath:Example.svg}}
*{{filepath:Example.svg|nowiki}}
*{{filepath:Example.svg|nowiki|300}}
*{{filepath:Example.svg|300}}
*{{filepath:Example.svg|300|nowiki}}

The idea of Bawolff at r80813#c13370 is good.

Maybe support the full syntax for set a size to an image ('/^([0-9]*)x([0-9]*)\s*(?:px)?\s*$/' and '/^[0-9]*\s*(?:px)?\s*$/', from Parser.php)

(In reply to comment #3)

The idea of Bawolff at r80813#c13370 is good.

Maybe support the full syntax for set a size to an image
('/^([0-9]*)x([0-9]*)\s*(?:px)?\s*$/' and '/^[0-9]*\s*(?:px)?\s*$/', from
Parser.php)

This was done in gerrit 11733