Page MenuHomePhabricator

Don't serve <script>fixalpha()</script> unconditionally from the server side
Closed, ResolvedPublic

Description

<!-- fixalpha -->

		<script type="text/javascript"> if ( window.isMSIE55 ) fixalpha(); </script> 
		<!-- /fixalpha -->

Should really only be served to IE5.5 browsers, no? :)


Version: unspecified
Severity: enhancement

Details

Reference
bz26878

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz26878.

Almost... Shouldn't it be in wikibits.js/the usage of IEFixes.js?

As it's seemingly done in Vector/Monobook themselves, and in IEFixes.js in a different way....

Bleh

Serving through PHP would break the cache or otherwise mess things up afaik.
But a seperate <script> element for it seems unneeded indeed, should be simple to move.

Although note that it should not run at document.ready but window.ready (not sure what the exact reason was, but I imagine it has to to with images being loaded or not)

Moving javascript-related bugs not related to ResourceLoader to JavaScript. This has no association with the ResourceLoader framework itself.

Also assigning to myself.

This was already done in r107327 (and followed-up in r108885). Not sure how/why it was put back in the HTML output?

Hm.. actually, they weren't put back. I fixed this bug in the aforementioned revisions. Marking fixed!