Page MenuHomePhabricator

Usage of $replyTarget on line 40 of ui/CodeRevisionView.php is undefined
Closed, DeclinedPublic

Description

Usage of $replyTarget on line 40 of ui/CodeRevisionView.php is undefined

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionView.php?view=annotate attributes it to r48132, but http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/CodeRevisionView.php?&pathrev=48132&r1=48131&r2=48132 seems to disagree...


Version: unspecified
Severity: minor

Details

Reference
bz26879

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz26879.
bzimport added a subscriber: Unknown Object (MLST).

??? $replyTarget is assigned null in the function's definition that "svn annotate" says you created in r76913.

I changed $repoName to $repo, and added function documentation...

But anyway, WFM is right, it's an IDE bug