Page MenuHomePhabricator

Move toggle for DoubleWiki to InitialiseSettings.php
Closed, ResolvedPublic

Description

Current code>
<pre>

CommonSettings.php

Experimental side-by-side comparison extension for wikisource. enabled brion 2006-01-13
FIXME: Needs $wmgUseDoubleWiki in InitialiseSettings.php
if(

'wikisource' == $site || 'sourceswiki' == $db || 'frwiktionary' == $wgDBname ) {
include( $IP.'/extensions/DoubleWiki/DoubleWiki.php' );

}
</pre>

This should be moved to init like the other per-wiki settings (makes searching a lot easier).

I don't know the exact syntax, but I think something like this:
<pre>

InitialiseSettings.php

'wmgUseDoubleWiki' => array(
'default' => false,
'wikisource' => true,
'sourceswiki' => true,
'frwiktionary' => true,
),

CommonSettings.php

// Experimental side-by-side comparison extension for wikisource. enabled brion 2006-01-13
if( $wmgUseDoubleWiki ) {

include( $IP.'/extensions/DoubleWiki/DoubleWiki.php' );

}
</pre>


Version: unspecified
Severity: normal

Details

Reference
bz26886

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz26886.
bzimport added a subscriber: Unknown Object (MLST).

jeluf wrote:

Your change has been completed.
Please reopen this ticket if anything went wrong.

The following configuration settings have been changed:

Index: InitialiseSettings.php

  • InitialiseSettings.php (revision 1534)

+++ InitialiseSettings.php (working copy)
@@ -8603,5 +8603,13 @@

'default' => false,
'foundationwiki' => true,

),
+
+'wmgUseDoubleWiki' => array(
+ 'default' => false,
+ 'wikisource' => true,
+ 'sourceswiki' => true,
+ 'frwiktionary' => true,
+),
+
);

You can find the entire config file at
http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php

Could you also remove the note or add something below it. It's a little confusing (since it's been added to InitialiseSettings.php now)
<pre>
// FIXME: Needs $wmgUseDoubleWiki in InitialiseSettings.php
</pre>

(In reply to comment #2)

Could you also remove the note or add something below it. It's a little
confusing (since it's been added to InitialiseSettings.php now)
<pre>
// FIXME: Needs $wmgUseDoubleWiki in InitialiseSettings.php
</pre>

I've removed it locally. It probably won't show up on noc until the next change to CommonSettings is synced; I didn't think syncing for a comment removal was really necessary.