Page MenuHomePhabricator
Create Task
Maniphest T28894

Kill $wgSkinExtensionFunctions
Closed, ResolvedPublic
Actions

Description

This variable is not used by any extension and is redundant with $wgSkinExtensionFunctions. It was added in r4934 to let extensions defining new skins add items to $wgValidSkinNames, but this is not needed now.

Version: unspecified
Severity: enhancement

Details

Reference
bz26894

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 ResolvedNoneT28894 Kill $wgSkinExtensionFunctions

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:21 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz26894.
• bzimport added a subscriber: Unknown Object (MLST).
IAlex created this task.Jan 23 2011, 8:47 PM
Krinkle added a comment.Jan 23 2011, 10:54 PM

$wgSkinExtensionFunctions === $wgSkinExtensionFunctions.
Which variable do you mean to kill and is redundant to which, something seems missing here. Did you mean $wgExtensionFunctions ?

IAlex added a comment.Jan 24 2011, 7:12 AM

Oops, yes, $wgSkinExtensionFunctions is redundant with $wgExtensionFunctions.

Peachey88 added a comment.May 5 2011, 10:05 AM

r87487

Marking fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL