Page MenuHomePhabricator

CreateRedirect extension needs code cleanup
Closed, ResolvedPublic

Description

The "CreateRedirect" extension was committed to SVN in r76578. It uses raw HTML and some other nastiness, which should probably be cleaned up. There may be XSS vulnerabilities in the code; using standard classes/functions dramatically reduces the likelihood of this (and it makes the code generally more readable and standardized).

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:21 PM
bzimport set Reference to bz26898.
bzimport added a subscriber: Unknown Object (MLST).

It seems that the original author hasn't touched this extension in years, but other regular contributors have.

Apparently only the DragonBall Encyclopedia uses it: http://wikiapiary.com/wiki/Extension:CreateRedirect

Is this an abandoned extension or not? Assuming Lowest priority for this bug report.

Krinkle added a project: Technical-Debt.
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).

Just a comment: this seems like a cleanup here would be a easy task. The body file is under 200 lines of code.

Suggest archive this. Can't image that that user can respond here.

Change 562647 had a related patch set uploaded (by DannyS712; owner: Edward Chernenko):
[mediawiki/extensions/CreateRedirect@master] Major rewrite and misc. UX improvements

https://gerrit.wikimedia.org/r/562647

Change 562647 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/extensions/CreateRedirect@master] Major rewrite and misc. UX improvements

https://gerrit.wikimedia.org/r/562647

Change 562647 merged by jenkins-bot:
[mediawiki/extensions/CreateRedirect@master] Major rewrite and misc. UX improvements

https://gerrit.wikimedia.org/r/562647