Page MenuHomePhabricator

cli install doesn't ask for a password if not provided
Closed, ResolvedPublic

Description

php maintenance/install.php --help

"--pass: The password for the wiki administrator. You will be

prompted for this if it isn't provided"

Expected: It asks for a password if not provided

What happens: It tries to use an empty password, then fail because it's too short.


Version: 1.18.x
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=36069

Details

Reference
bz26911

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz26911.

I should fix this. Now, should it prompt or should it continue as is and not say that it will prompt.

I'd try to implement the prompt, as it's a nice idea, but if it turns out to be too much work, just make the parameter required and change the description.

It fails now, but the message is unhelpful: Internal error when setting a password for the admin "none": Passwords must be at least 1 character.

Change Ibea29858 should fix this.
https://gerrit.wikimedia.org/r/12697

wmf.amgine3691 wrote:

Bug 36069 is related to this issue.

If I'm not mistaken, this is now fixed with: "Param pass required!" Please re-open otherwise.