Page MenuHomePhabricator

Re-uploading a deleted file fails, warning cannot be ignored
Closed, ResolvedPublic

Description

Upload a file to mediawiki 1.18alpha (r79596)

Delete that file.

Reupload a file of the same name. A warning appears, which is helpful. In the upload form, at this point, the filename is still present under "Source filename:"

Click at bottom of form on "Ignore warning and save file anyway". Now the upload fails with message above the (now empty!) "Source filename:" : "The file you uploaded seems to be empty. This might be due to a typo in the file name. Please check whether you really want to upload this file."

Repeatable...


Version: 1.17.x
Severity: major

Details

Reference
bz27021

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:17 PM
bzimport set Reference to bz27021.
bzimport added a subscriber: Unknown Object (MLST).

Thanks for the bug report. We're in the middle of the release of 1.17 right now, though, so it may take a week or so for us to get to this.

Agreed for 1.18, but please check the behavior under 1.17. The same or very similar bug occurred in a much earlier 1.17 version (SVN number not know). It disappeared later after an update, so I did not report.

Bryan.TongMinh wrote:

I'm marking this as depending on bug 26611, as somebody should at least check if this problem occurs in 1.17 as well. I suspect it will as I do not remember significant changes to the upload code in 1.18.

Bryan.TongMinh wrote:

Can confirm, both on 1.17 and 1.18.

Bryan.TongMinh wrote:

Fixed in r81197.

@mah, in general you can assign upload related stuff that needs investigating or fixing before the 1.17 release to me.

Bryan.TongMinh wrote:

*** Bug 26214 has been marked as a duplicate of this bug. ***

Bryan.TongMinh wrote:

*** Bug 27090 has been marked as a duplicate of this bug. ***

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:19 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:23 AM