Page MenuHomePhabricator

Update any calls of deprecated (and the method calls wfDeprecated()) methods in extensions pre 1.17 branch
Closed, ResolvedPublic

Description

Per r81204 and r81205, it wouldn't be nice releasing extensions (and even more so on WMF used ones), to be having deprecated warnings everywhere in the 1.17 release


Version: unspecified
Severity: minor

Details

Reference
bz27041

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:18 PM
bzimport set Reference to bz27041.
bzimport added a subscriber: Unknown Object (MLST).

Database::newFromParams - 2 usages
Database->escapeLike - 13 usages
Database->immediateBegin - 2 usages in DSMW

Being kicked off my computer, my little sister wants to play games ;) Will carry on later

Image::__construct - 5 usages
SiteStats::admin - SMW
wfEncryptPassword - 3 usages in auth

wfLoadExtensionMessages - Doesn't warn in 1.17

userMailer - NewUserNotif

LogReader::construct - MetavidWiki
LogViewer::
construct - MetavidWiki

WikiError::construct - SemanticForms
WikiError::isError - 19 usages
WikiErrorMsg::
construct - SemanticForms

SpecialPage::addPage - 18 usages

And that concludes the list. Obviously, this doesn't include any called via vodoo, or other unobvious ways, but gives us a reasonable idea of what's going on.

A couple of them will be only warning in 1.18, so that needs paying attention to, but if it was set to start warning in 1.17, they need tidying up. (I know some people do tidy them up when they mark them as deprecated with a warning)

wfEncryptPassword in r81240

userMailer in r81241

Database->immediateBegin in r81242

SiteStats::admin in r81243

TODO:

Database::newFromParams - 2 usages

Image::__construct - 5 usages

wfLoadExtensionMessages - Doesn't warn in 1.17

LogReader::construct - MetavidWiki
LogViewer::
construct - MetavidWiki

WikiError::construct - SemanticForms
WikiError::isError - 19 usages
WikiErrorMsg::
construct - SemanticForms

SpecialPage::addPage - 18 usages

Database::newFromParams in r81244

Image::__construct in r81245

TODO:
LogReader::construct - MetavidWiki
LogViewer::
construct - MetavidWiki

SpecialPage::addPage - 18 usages

Nothing TODO:
wfLoadExtensionMessages - Doesn't warn in 1.17

Backed out in r78094 from 1.17
WikiError::construct - SemanticForms
WikiError::isError - 19 usages
WikiErrorMsg::
construct - SemanticForms

TODO:
What are these replaced with?
LogReader::construct - MetavidWiki
LogViewer::
construct - MetavidWiki

SpecialPage::addPage - 18 usages
r81248

uniwiki and Wikidata can go to hell.

Nothing TODO:
wfLoadExtensionMessages - Doesn't warn in 1.17

Backed out in r78094 from 1.17. Logged bug 27066 for the SF components
WikiError::construct - SemanticForms
WikiError::isError - 19 usages
WikiErrorMsg::
construct - SemanticForms

I'm guessing the LogReader/LogViewer stuff isn't a blocker for release... They were marked deprecated before 1.14 was branched.

bug 27071 logged for that one.

What remains isn't really a blocker for release. Certainly not for deployment.

Marking RESOLVED FIXED as I look to have tidied everything up, and marked for backport where appropriate