Page MenuHomePhabricator

User allowed to insert a table with 0 rows.
Closed, DeclinedPublic

Description

Author: nadeejw

Description:
Steps to reproduce:

  1. Navigate to wikimedia main page.
  2. Open a page in edit mode.
  3. Click on the 'Table' button on the 'Advanced' toolbar.
  4. Enter '0' for 'Rows' field and click on the 'Insert' button.

Actual results:
User allows to insert a table of '0' rows.

Expected results:
System should be display 'You cannot insert a table with zero rows or columns' message.
Note: User cannot insert a table with '0' columns.

URL : http://prototype.wikimedia.org/rc-en/index.php/Main_Page
Version : 1.17alpha (r80667)


Version: unspecified
Severity: minor

Details

Reference
bz27058

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:19 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz27058.

The error is in fact shown if columns is 1 and rows is 0.

However if the "Add header row" checkbox is ticked then 0 rows is allowed.

We can't decide and should not 'disallow' a user from creating a table header without rows. This could be useful for demonstration purpuses if no content is available yet.

The following renders just fine, no problems:

{| class="wikitable"

-

! Header
! text

}
  • Moving issue from MediaWiki/pag editing to Extensions/WikiEditor as this toolbar is not part of the MediaWiki core.
  • Marking WONTFIX.

Toggling the FCK editor on and off repeatedly (when this extension is installed into 1.17) show will add one row so that there is 1 instead of 0.