Page MenuHomePhabricator

System does not validate the 'Email' field properly in the 'User preferences'
Closed, DeclinedPublic

Description

Author: nadeejw

Description:
Steps to reproduce:

  1. Logged in user navigates to wiki media main page.
  2. Click on the 'User preferences' link.
  3. Enter invalid email address to the 'E-mail (optional)*' field. (Eg. test@test)
  4. Click on the 'Save' button.

Actual results:
System accepts the email address and 'A confirmation e-mail has been sent to the nominated e-mail address...' message displayed.

Expected results:
'The e-mail address cannot be accepted as it appears to have an invalid format. Please enter a well-formatted address or empty that field.' message should displayed.

URL : http://prototype.wikimedia.org/rc-en/index.php/Main_Page
Version : 1.17alpha (r80667)


Version: 1.17.x
Severity: normal
OS: Windows XP
Platform: PC

Details

Reference
bz27061
TitleReferenceAuthorSource BranchDest Branch
configure-projects: add an issue allowlist and tidy log outputrepos/releng/gitlab-settings!10brennenwork/brennen/allowlistmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:20 PM
bzimport set Reference to bz27061.
bzimport added a subscriber: Unknown Object (MLST).

test@test is actually a valid email, to the extent if it was on the local network

To determine if an email was actually valid, we would have to actually start an SMTP connect to see if the address would be received or not.

I'm thinking this sort of check could and should be written as an extension.

The confirmation email is the validation check step. The correct way to validate an email address is to try to send email to it.