Page MenuHomePhabricator

Fetch MediaWiki:Filedelete-reason-dropdown from MediaWiki:Deletereason-dropdown.
Closed, InvalidPublic

Description

Author: rehman.wikimedia

Description:
The deletion dropdown at Commons currently fetches from two pages:

  • MediaWiki:Deletereason-dropdown
  • MediaWiki:Filedelete-reason-dropdown

It would be more efficient to fetch from a single page, preferable the first. A simple switch function could be placed to work as it does currently. This would avoid duplicating general deletion criteria between both pages.

This was discussed and considered an uncontroversial change.


Version: unspecified
Severity: minor

Details

Reference
bz27067

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz27067.
bzimport added a subscriber: Unknown Object (MLST).

Um, only Filedelete-reason-dropdown should be shown on file deletion pages, why are there two?

rehman.wikimedia wrote:

(In reply to comment #1)

Um, only Filedelete-reason-dropdown should be shown on file deletion pages, why
are there two?

Exactly. So thats the reason of this request; remove the fetching of the second page...

(In reply to comment #1)

Um, only Filedelete-reason-dropdown should be shown on file deletion pages, why
are there two?

I think deletereason is ment to a "common" list, but its pointless if we don't have a dedicated page/article list for deletions.

rehman.wikimedia wrote:

(In reply to comment #3)

I think deletereason is ment to a "common" list, but its pointless if we don't
have a dedicated page/article list for deletions.

Am working on creating a detailed page for the deletion criteria:
http://commons.wikimedia.org/wiki/User:Rehman/Proposals/Deletion_criteria

This is just the first step...

rehman.wikimedia wrote:

The change is uncontroversial, I don't see why it should take so long to do it...

Just to clarify, you are reporting:
*Normal articles use: Deletereason-dropdown
*File delete pages use: Filedelete-reason-dropdown
for their respective delete reason drop down list, where instead you want both pages to use Deletereason-dropdown, and want Filedelete-reason-dropdown to no longer do anything? With the reason being its less work for admins to maintain a single list.

The first time I read this I thought you were complaining that file deletion pages had both dropdowns on them.

This was discussed and considered an uncontroversial change.

btw, its extraordinary unlikely that this would be changed just for commons. It will probably be changed either for everyone, or no one. (Or it might be changed so that if filedelete-reason-dropdown is empty, the file deletion page would use the normal drop down instead). Per-wiki configuration is not this fine grained.

rehman.wikimedia wrote:

(In reply to comment #6)

btw, its extraordinary unlikely that this would be changed just for commons. It
will probably be changed either for everyone, or no one. (Or it might be
changed so that if filedelete-reason-dropdown is empty, the file deletion page
would use the normal drop down instead). Per-wiki configuration is not this
fine grained.

So if I just delete the "filedelete-reason-dropdown" from Commons, would that solve the problem?

No, I'm saying one potenital solution is to change it so that if the message is empty that behaviour would happen, that is not the current behaviour.

rehman.wikimedia wrote:

(In reply to comment #8)

No, I'm saying one potenital solution is to change it so that if the message is
empty that behaviour would happen, that is not the current behaviour.

Please forgive me, but I don't understand. ;) So, if I blank "Filedelete-reason-dropdown" (not delete), it would fetch only from "Deletereason-dropdown"?

Or are you saying that this feature of "dont fetch if blank" is something that could be implemented?

It could be implemented. It is not right now.

The only way to do it as the code is now without modifying the code is to replace mediawiki:Filedelete-reason-dropdown with {{mediawiki:Deletereason-dropdown}}. Then it would load from the other one (Its disgusting that that works, but meh. I only thought of it because i noticed you guys used parser funcs on the pages on commons).

rehman.wikimedia wrote:

(In reply to comment #10)

The only way to do it as the code is now without modifying the code is to
replace mediawiki:Filedelete-reason-dropdown with
{{mediawiki:Deletereason-dropdown}}. Then it would load from the other one (Its
disgusting that that works, but meh. I only thought of it because i noticed you
guys used parser funcs on the pages on commons).

Okay seems to be working :) Any idea what would happen if "Filedelete-reason-dropdown" is deleted?

(In reply to comment #11)

(In reply to comment #10)

The only way to do it as the code is now without modifying the code is to
replace mediawiki:Filedelete-reason-dropdown with
{{mediawiki:Deletereason-dropdown}}. Then it would load from the other one (Its
disgusting that that works, but meh. I only thought of it because i noticed you
guys used parser funcs on the pages on commons).

Okay seems to be working :) Any idea what would happen if
"Filedelete-reason-dropdown" is deleted?

Then it will fallback to the default value of the message, like any other message in the software. Which is:
*Common delete reasons\ Copyright violation\ Duplicated file.

Marking invalid as this is neither a feature request nor a bug in the software.