Page MenuHomePhabricator

CodeReview has invalid CSS
Closed, ResolvedPublic

Description

w3 reckons 1 error, and 5 warnings

135 .mw-codereview-diff .meta Value Error : color darkcyan is not a color value : darkcyan darkcyan

Warnings:
163 Same colors for color and background-color in two contexts .mw-codereview-struck td and .mw-wordcloud-size-5
163 Same colors for color and background-color in two contexts .mw-codereview-status-reverted:hover td and .mw-wordcloud-size-5
163 Same colors for color and background-color in two contexts .mw-codereview-status-reverted:hover and .mw-wordcloud-size-5
175 Same colors for color and background-color in two contexts .mw-codereview-status-reverted td and .mw-wordcloud-size-8
175 Same colors for color and background-color in two contexts .mw-codereview-status-reverted and .mw-wordcloud-size-8

See url for direct link to http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/modules/ext.codereview.css?view=co in the w3 validator


Version: unspecified
Severity: trivial
URL: http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fsvn.wikimedia.org%2Fviewvc%2Fmediawiki%2Ftrunk%2Fextensions%2FCodeReview%2Fmodules%2Fext.codereview.css%3Fview%3Dco&profile=css21&usermedium=all&warning=1&lang=en

Details

Reference
bz27096

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz27096.
bzimport added a subscriber: Unknown Object (MLST).

Can we just use #008b8b instead to make it happy? :S At least for the error...

Nobody really uses the CSS validator much as it tends to come up with warnings that are... dubious.

The warnings here don't make any sense; does it think that .mw-codereview-struck and .mw-wordcloud-size-5 are going to be used in the same place? These are not actually problems at all, as those class styles are never used together.

'darkcyan' is indeed technically not listed in CSS 2.1, but it is standard in the CSS 3 colors module and is supported by all known browsers. Wouldn't hurt to swap it to a hex code, but not a lot of reason for it either.

(In reply to comment #3)

WONTFIX then?

Let's go with "fixed" once "darkcyan" is removed. The description text can go in a CSS comment next to the hex code for clarification.

The warnings can safely be ignored.