Page MenuHomePhabricator

Regression in WebRequest: PHP warning on every non-PATHINFO'd page request
Closed, ResolvedPublic

Description

Page hits that don't have PATHINFO stuff on them but use bare script + query string such as:

http://lazarus.local/trunk/index.php?title=Special:Foobar

spew a warning like this:

<b>Warning</b>: Invalid argument supplied for foreach() in <b>/Library/WebServer/Documents/trunk/includes/WebRequest.php</b> on line <b>128</b><br />

This error is due to something other than an array being returned from WebRequest::getPathInfo(), which has apparently been rewritten in r81363


Version: 1.18.x
Severity: blocker

Details

Reference
bz27099

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz27099.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

This error is due to something other than an array being returned from
WebRequest::getPathInfo(), which has apparently been rewritten in r81363

Well, it was created in r81363. Could you check r81373?

(In reply to comment #1)

(In reply to comment #0)

This error is due to something other than an array being returned from
WebRequest::getPathInfo(), which has apparently been rewritten in r81363

Well, it was created in r81363. Could you check r81373?

No, does not work :-( Still seeing this warning on Translatewiki

[02-Feb-2011 07:31:03] PHP Notice: Undefined variable: matches in /www/w/includes/WebRequest.php on line 109