Reflect current revision status in links within CR work flow
Closed, DeclinedPublicFeature
Actions

Assigned To

None

Authored By

	Krinkle
	Feb 4 2011, 12:31 AM

Description

Within the CodeReview workflow it'd be nice to have some reference to it's current state (kinda like how bugzilla has the .bz_closed class on the links and the "RESOLVED FIXED" in title-attribute /hover tooltip).

Having something like the following:

or
<span class="mw-codereview-revision-status-new" title="ialex - reverted"
<a class="" href="http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270">r70270</a></span>

instead of the current output:
<a href="http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270" title="Special:Code/MediaWiki/70270">r70270</a>

If more people find it helpful, including tags may be useful as well.

Version: unspecified
Severity: enhancement

Details

Reference: bz27147

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:12 PM

• bzimport added a project: MediaWiki-extensions-CodeReview.

• bzimport set Reference to bz27147.

• bzimport added a subscriber: Unknown Object (MLST).

Krinkle created this task.Feb 4 2011, 12:31 AM

We have the CSS styles already applied to rows?

I believe this is meant to be for the inline references in comments and the follow-ups lists, where current there is no check for status and no special formatting.

Should be pretty straightforward to do: pull the record when making the link, and add a css class. This should be abstracted and used consistently for the inline rXXXX and for the generation of paging links and follow-ups.

[It would be SUPER cool if we could find a way to tie this in for bugzilla as well, but that'd be a separate bug. Would need a way to query the wiki cleanly from the BZ side, maybe over API.]

And ofcourse now, we have MaxSems popup things...

(In reply to comment #2)

[It would be SUPER cool if we could find a way to tie this in for bugzilla as
well, but that'd be a separate bug. Would need a way to query the wiki cleanly
from the BZ side, maybe over API.]

See bug 28489 :)

• demon unsubscribed.Aug 19 2015, 5:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 5:23 PM

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:00 AM

Aklapper removed a subscriber: • wikibugs-l-list.

Bugreporter closed this task as Declined.Thu, Apr 11, 1:56 PM

Reflect current revision status in links within CR work flowClosed, DeclinedPublicFeatureActions

Description

Details

Event Timeline

Reflect current revision status in links within CR work flow
Closed, DeclinedPublicFeature
Actions