Check if Status::isGood() and Status::isOk() are used appropriately in FileRepo
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Feb 4 2011, 8:00 PM

Description

Author: Bryan.TongMinh

Description:
Almost always you want Status::isGood() not Status::isOk(). Each use of those functions needs to be checked in FileRepo, because I have found cases where I believe isGood() is more appropriate than isOk(). In addition in some cases the member variable $ok is accessed directly. This should be fixed to use one of the accessor methods.

Version: unspecified
Severity: normal

Details

Reference: bz27161

	Title	Reference	Author	Source Branch	Dest Branch
	Correctly check composer before install	repos/releng/cli!44	addshore	hack-around-composer-check	main

Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:13 PM

• bzimport added a project: MediaWiki-File-management.

• bzimport set Reference to bz27161.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Feb 4 2011, 8:00 PM

Bryan.TongMinh wrote:

LocalFileMoveBatch done in r83245; LocalFileRestoreBatch done earlier.

isOK() is grossly misleading, can we rename it?

Is there anything to do here?

Bryan.TongMinh wrote:

No.

• Gilles added a project: Multimedia.Dec 4 2014, 10:21 AM

• Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM

Check if Status::isGood() and Status::isOk() are used appropriately in FileRepoClosed, ResolvedPublicActions

Description

Details

Event Timeline

Check if Status::isGood() and Status::isOk() are used appropriately in FileRepo
Closed, ResolvedPublic
Actions