Page MenuHomePhabricator

User preferences are ignored
Closed, ResolvedPublic

Description

The user's preferences for collapsiblenav and editwarning are ignored in the vector extension for 1.17.
Steps to reproduce:

  1. Disable both settings in your preferences (or enable it, if they they are globally disabled).
  2. Open any page in editing mode.
  3. Type something and click any link to leave the page.

Expected result:
You should be able to leave the page without being asked if you want to do so, and you should see the left navigation uncollapsed.

Actual result:
Both settings are ignored.

It seems as if in Vector.hooks.php in $features the preferences should be duplicated to requirements and vice versa as it is done in the WikiEditor extension.


Version: unspecified
Severity: major

Details

Reference
bz27213

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:16 PM
bzimport set Reference to bz27213.

Yes, you are correct, good catch. This is resolved in r81640.