Page MenuHomePhabricator

UploadWizard: Validation is broken?
Closed, ResolvedPublic

Description

Author: neilk

Description:
Validation appears not to be working at the details step.

When the 'submit' button is clicked, any empty required fields or other fields that fail to pass their own validation criteria should trigger red error messages above the problematic fields.

The wizard does seem to be aware that something is wrong because it refuses to go to the next step.


Version: unspecified
Severity: enhancement

Details

Reference
bz27232

Related Objects

StatusSubtypeAssignedTask
DeclinedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
InvalidNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedkaldari
ResolvedNone
ResolvedNone
Resolvedkaldari
ResolvedNone
DeclinedNone
Resolvedkaldari
ResolvedNone
DeclinedNone
Resolvedkaldari
Resolvedkaldari
ResolvedNone
Resolvedkaldari
DeclinedNone
ResolvedNone
ResolvedNone
ResolvedNone
InvalidNone
Resolvedkaldari
Resolvedkaldari
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedkaldari
Declinedkaldari
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
ResolvedNone
Resolvedkaldari
Resolvedkaldari
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedkaldari
ResolvedNone
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz27232.

neilk wrote:

Validation isn't broken, but it can be better aligned with the new layout. Changing it to a non-critical bug, but we still want to do this before 1.0.

neilk wrote:

Validation for multiple deeds doesn't seem to be working.

  • upload multiple files,
  • then select "pick copyright info individually" at release rights
  • try to submit details page without filling out deeds, should cause validation errors above deeds, but doesn't.
  • other validation appears to be working, though.

neilk wrote:

Nice to have:

  • if the validator listed the number of errors near the page submit button.
  • if the total number of errors, and the errors themselves, flashed yellow (and faded to white) every time one pressed submit.

Fixed except for the nice-to-haves in r84216.

neilk wrote:

Since this is fixed, it's fixed. ;)

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:29 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM