Messages do not work in 1.15.1 <= MediaWiki < 1.16
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Feb 8 2011, 4:14 AM

Description

Author: wikimedia-bugzilla

Description:
Fix for version check

In the latest version of the Maps extension, none of the messages work properly in MediaWiki 1.15.x -- instead, only "<string-id>" is inserted into the page (e.g. "<maps-error-invalid-layerdef>".)

After spending a decent chunk of time tearing my hair out, I tracked down the problem to the version check in Maps.php that checks for version 1.16 -- it incorrectly excludes MediaWiki 1.15.x where x > 0. The attached patch fixes the logic.

Version: unspecified
Severity: normal

Attached:

Maps.php.diff465 BDownload

Details

Reference: bz27234

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM

• bzimport added projects: MediaWiki-extensions-Maps, good first task, I18n.

• bzimport set Reference to bz27234.

• bzimport created this task.Feb 8 2011, 4:14 AM

wikimedia-bugzilla wrote:

FYI, this bug exists in Validator as well. It looks like you have a hand in that extension as well, and since no component exists on this bugzilla for it and the problem/fix is exactly the same, I'm attaching a patch for it to this bug as well.

wikimedia-bugzilla wrote:

Fix for version check in the Validator extension (practically identical to the Maps diff)

Attached:

Validator.php.diff498 BDownload

Thanks for reposting the issue; it's already been fixed on svn trunk though :)

I copied the wrong check over to at least 5 extensions before noticing how wrong it was >_>

	F7199: Validator.php.diff
	Nov 21 2014, 11:18 PM

Messages do not work in 1.15.1 <= MediaWiki < 1.16Closed, ResolvedPublicActions

Description

Details

Event Timeline

Messages do not work in 1.15.1 <= MediaWiki < 1.16
Closed, ResolvedPublic
Actions