Page MenuHomePhabricator

Password reset form does not include domain information
Closed, ResolvedPublic

Description

The password reset form does not include domain information, or set the domain when resetting the password. This causes problems with the LDAP authentication plugin when passwords are reset.

After the user's password is reset they are logged in, but their session does not have wsDomain set, leading to strange behavior.


Version: unspecified
Severity: enhancement

Details

Reference
bz27310

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:23 PM
bzimport set Reference to bz27310.
bzimport added a subscriber: Unknown Object (MLST).

Actually, this is worse in trunk than I thought. Password changing no longer works with LDAP at all. Since the domain isn't set when the form is loaded, wgAuth->allowPasswordChange() returns false.

I've gotten to a point where password canges work by including the domain information in SpecialResetpass (r81978), but the session issue persists.

After the user changes the password, and is logged in, wsDomain disappears from the session. Somehow the user must be getting a new session without the domain properly added.

Actually, on further testing r81978 fixes this (thanks to Reedy for his midas touch).