Page MenuHomePhabricator

Update sortable table script to latest version
Closed, InvalidPublic

Description

The sortable table we have in wikibits.js is an old version of the script.
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/wikibits.js?view=markup#l517

We should:

  • Check if we made any adjustments to it
    • if so, do we still need them or are they fixed upstream in the mean time ?
  • Check out the latest version to see if it broke anything (ie. if it still supports class="unsortable", and <th> as head in a <tr> and not require <thead>)
  • Rewrite that new version [1] in an object so we can easily put it somewhere in /resources/ without conflicting with names of the legacy version in wikibits.js or otherwise polluting the global/window namespace.
  • Do some testing to verify that existing tables work fine
  • Remove the old script and the sortables_init-call from wikibits.js
  • Load the new script by default and call the Init() of it

[1] http://yoast.com/articles/sortable-table/
Tags: window.ts tablesort sortable table wikitable


Version: 1.18.x
Severity: enhancement

Details

Reference
bz27389

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:16 PM
bzimport set Reference to bz27389.

No love for Bug 8028#c15 ? It cuts execution time by 6/7 for IE. If no thead is a prerequisite, could probably done as well.

This bug is no longer valid as the script has been removed in favour of the jquery plugin.