Page MenuHomePhabricator

Manual revision association won't accept "rXXXXX"
Closed, ResolvedPublic

Description

Just tried putting in rXXXXX rather than XXXXX, it refreshed, and did nothing

As we can have Special:Code/MediaWiki/XXXXX and Special:Code/MediaWiki/rXXXXX, might aswell allow the r there


Version: unspecified
Severity: minor

Details

Reference
bz27400

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:16 PM
bzimport set Reference to bz27400.
bzimport added a subscriber: Unknown Object (MLST).

And it should in general do error and success messages. If I add 'hello' it also just submits silently.

r82169 makes it accept rXXXXX

Do we need the success and error messages? Success seems slightly redundant, as the result is it appears...

For error.. We have a couple of types. Ones that are in the wrong format, ie not XXXXX or rXXXXX.

Then, if the revisions is in a correct format, but it hits either of

if ( $rev > $this->getId() ) {

or

if ( $rev < $this->getId() ) {

Do we really need that level of verbosity?

Pinging this again.

If no input, I'm gonna resolve as fixed :P