Page MenuHomePhabricator

CodeReview's diff-line background causes disappearing descenders
Closed, ResolvedPublic

Description

Cropped screenshot

Adding a green background to the <ins> tags in CodeReview makes the descenders disappear. See attached screenshot.

I don't like it anyway, the contrast is too low.


Version: unspecified
Severity: minor

Attached:

CodeReview_green_background.png (67×201 px, 4 KB)

Details

Reference
bz27416

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz27416.

I'll check this out later. For now I'll just note to self and others that the reason for the addition of the background was better detection of whitespace.

sometimes a line looked like:

  • function fooBarThing( $here, $that = FOO_BAR, $somethingElse ) {

+ function fooBarThing( $here, $that = FOO_BAR, $somethingElse ) {

Where one may look for several seconds to catch the difference wheares with a background you'd notice the former line has a space after the opening curly bracket.

Reverted r82064 in r84818, reopening bug 27375