Page MenuHomePhabricator

Special:Types non-functional on 1.17
Closed, ResolvedPublic

Description

Some recent changes in MediaWiki make Special:Types not show anything.

The TypesPage class has a getSQL method that returns the SQL to create the types list, but it's not getting called any more in 1.17 and above. Looks like getQueryInfo should be used instead. I've given it a try, but am not sure how to return the equivalent query with the UNIONs.


Version: unspecified
Severity: normal

Details

Reference
bz27440

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:19 PM
bzimport set Reference to bz27440.

It is supposed to fall back to getSQL(), so there's something wrong with QueryPage if it's not being called when getQueryInfo() is commented.

So we should file a bug on QueryPage?

Probably, although the code at QueryPage looks perfectly good. Needs debugging.

I found the bug, someone decided to swap the limit and offset params of doQuery at r78786. Awesome way to introduce subtle bugs! Fixed in r82636.