Page MenuHomePhabricator

<pages> tag from ProofreadPage extension broken on enwikisource since 1.17 upgrade
Closed, ResolvedPublic

Description

Author: adrian

Description:
Since today's upgrade to 1.17, the <pages> tag[1] from the Proofread Page extension[2] has been partly broken. The "fromsection" and "tosection" parameters to that tag[3] are supposed to ensure that only specfic labelled sections are transcluded from the first and last pages (respectively) in the range of pages transcluded. (These are "sections" as defined by Labelled Section Transclusion.[4])

For concrete examples see [5,6]; in each case the end of the previous article and the beginning of the next article are included because the whole page is being transcluded rather than only the labelled sections specified.

This definitely only started happening today. It is a show-stopper bug for Wikisource, affecting as it does probably thousands, and certainly many hundreds, of works.

[1] http://en.wikisource.org/wiki/Help:Proofread#Full-page_transclusion
[2] http://www.mediawiki.org/wiki/Extension:Proofread_Page
[3] http://en.wikisource.org/wiki/Help:Proofread#Combination_multipage_and_partial_transclusion
[4] http://www.mediawiki.org/wiki/Extension:Labeled_Section_Transclusion
[5] http://en.wikisource.org/wiki/1911_Encyclop%C3%A6dia_Britannica/Cape_Town
[6] http://en.wikisource.org/wiki/Dawkins,_James_%28DNB01%29


Version: unspecified
Severity: major

Details

Reference
bz27454

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz27454.
bzimport added a subscriber: Unknown Object (MLST).

It would seem to be related to parts of ProofreadPage as normal #lst tests work fine. Catrope had a look and suspects that it may be somewhere in r:73215

(In reply to comment #1)

It would seem to be related to parts of ProofreadPage as normal #lst tests work
fine. Catrope had a look and suspects that it may be somewhere in r:73215

urk that didn't work

https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/73215

adrian wrote:

Any idea when the fix will be applied to en.wikisource?