Page MenuHomePhabricator

Remove white background-color from ul.gallery
Closed, ResolvedPublic

Description

Related to the fixes for Bug 3276.

<gallery> hat a white background now which looks weird, see URL for an example.


Version: unspecified
Severity: minor
URL: http://commons.wikimedia.org/wiki/File:Haus_Neuerburg_K%C3%B6ln_-_Turm_%289699-9701%29.jpg

Details

Reference
bz27458

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz27458.

Combined patch is attached at Bug:27338

shoulda just duped this when I commmented,

  • This bug has been marked as a duplicate of bug 26470 ***

This is not ad dupe. I do not speak about a checkered background.

ul.gallery is set to background:white which looks weird, please see http://commons.wikimedia.org/wiki/File:Haus_Neuerburg_K%C3%B6ln_-_Turm_%289699-9701%29.jpg section "other versions"

it is a dupe of that bug since that one gives users a preference of what they want. Solid white background could be done.

Also, people trying to fix that bug caused your bug report. You should make sure your voice is heard on that bug since it is the one that people are working on.

  • This bug has been marked as a duplicate of bug 26470 ***

I'm sorry, but this is not a dupe.
This bug is about the background of the *whole* gallery,
the other about the background of single pictures.

Please have a look at the screenshot: There's no transparent image in it.

I've avoided re-duping this bug, but would like some feedback: You say look at the "Other Versions" row and I can see that this row does have a different background.

Is this (an example of) the problem this bug seeks to fix?

Yes. The background of [[Commons:Template:Information]] is a light blue. The *whole* gallery has a white background now, instead of transparent as before.

This white background color is not new. It's been white since r54097:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?&pathrev=54097&r1=54096&r2=54097#l713

Since 1.17 they are UL's and the selector was changed to ul.gallery in r77411 :
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?&pathrev=77411&r1=77410&r2=77411#l787

Commons specifically has had some javascript running that changed the layout of tables, this, as a side-effect, caused that core css not to apply because it changed the classes.

Now that the fluid functionality is in core, the core classes apply again (as they did on all other wikis anyways).

In the spirit of lines no longer going through tables, images and lists (bug 26449, solved in r79087 and r79091) ul.gallery's background may be dropped like-wise.

Changing summary as, again, this is not new in 1.17 at all.