Page MenuHomePhabricator

Rejecting a change by an IP puts link to IP userpage in default summary, not xyr contribs as expected
Closed, ResolvedPublic

Description

On enwikinews, rejecting an edit on a sighted article gives the following default edit summary:

Rejected the last change (by [[User:127.0.0.1|127.0.0.1]]) and restored revision 12345678 by Username

As IPs don't generally have userpages, FlaggedRevs should follow the convention of linking to IP talk pages:

Rejected the last change (by [[Special:Contributions/127.0.0.1|127.0.0.1]]) and restored revision 12345678 by Username

Example diff:
http://en.wikinews.org/w/index.php?title=Former_Egyptian_president_Mubarak_reportedly_ill,_may_be_in_coma&curid=245306&diff=1180742&oldid=1180738

As of this post, enwikinews has FlaggedRevisions r82223, and MediaWiki version 1.17wmf1.


Version: unspecified
Severity: enhancement
URL: http://en.wikinews.org/w/index.php?title=Former_Egyptian_president_Mubarak_reportedly_ill,_may_be_in_coma&curid=245306&diff=1180742&oldid=1180738

Details

Reference
bz27505

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport set Reference to bz27505.
bzimport added a subscriber: Unknown Object (MLST).

This is partly done to save space (due to the annoying 255 char summary limit).

We could possibly use [[User:127.0.0.1]] as a compromise.

Wait, do you want the link to go to the user talk page or the contributions page?

(In reply to comment #2)

We could possibly use [[User:127.0.0.1]] as a compromise.

I assume you mean "User talk" :)

Looking at the page, I think he wants Special:Contributions. The left column of the link has Special:Contributions (and a blue link), the right column has User: (and a red link).

It's just that rollback, ~~~, etc appears to link to Special:Contributions for logged-out users, which makes sense, considering IP userpages are exceedingly rare.

As far as I can tell, $wgMaxNameChars has a default value of 255, which would break the edit summary anyway. Adding [[Special:Contributions/XXX.XXX.XXX.XXX|XXX.XXX.XXX.XXX]] still leaves 136 characters for the other username, which is more than ample, surely, for most usernames?

For comparision, the following is 136 characters long:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean nec tortor massa. Nulla quis ultricies leo. Nunc rhoncus mi in orci sed.

The following is 153 characters long:
Cras bibendum erat in risus sagittis interdum. Duis eget placerat dui. Sed rutrum laoreet neque et dictum. Curabitur mauris sem, aliquam posuere posuere.

How many usernames are four sentences long?

As an aside, according to the relase notes, 1.18 has [[Special:Contribs]] as a redir to [[Special:Contributions]].

By the way, it's r79795 for the Contribs -> Contributions thing.

This has nothing to do with maxnamechars, but with the total summary length, bug 4715.

(In reply to comment #8)

This has nothing to do with maxnamechars, but with the total summary length,
bug 4715.

Well maybe in terms of pathological usernames. But the main problem is reverting 3-4 users at once, especially in multibyte heavy languages in unicode (cutting the effective length in half in cases). Links like [[User:X|X]] are already more than double the size of X.

(In reply to comment #7)

By the way, it's r79795 for the Contribs -> Contributions thing.

I'll wait for that to be reviewed.