Page MenuHomePhabricator

Enforce restrictions on internal name of a gadget in the UI
Closed, ResolvedPublic

Description

In the README file for the Gadgets extension, around line 51 please change
"Note that the internal name must start with an ASCII letter, ..."
to
"Note that the internal name must start with an ASCII letter, must not be longer than 25 bytes, ..."
per bug 19410 and bug 19408.

(I just experienced this problem on la.wikipedia and it took me a while to find the cause - would have been easier if this (non-obvious) limitation had been documented in the README file in the first place.)

Thank you in advance!


Version: unspecified
Severity: enhancement

Details

Reference
bz27512

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport set Reference to bz27512.
bzimport added a subscriber: Unknown Object (MLST).

Better yet, enforce the limitation in the UI.

Documentation updated in r82389

Retitling per Nikerabbit

(In reply to comment #0)

(I just experienced this problem on la.wikipedia and it took me a while to find
the cause

We had a similar problem on pt.wikipedia because of accented characters.
https://pt.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&action=history
I believe the extension should provide some error message to the user in case the choosen name is not valid.

Fixed in the 2.0 branch. Backporting unlikely. Patches are welcome.