database::update $conds default causes database::makeList failure
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Feb 18 2011, 7:10 PM

Description

Author: wmf.amgine3691

Description:
"Database::makeList called with incorrect parameters" does not unambiguously show error is with database::update calling parameters.

Possible fix:

if ( is_array( $conds ) ) {
  $sql .= " WHERE " . $this->makeList( $conds, LIST_AND );
}elseif( $conds != '*' ){
  throw new DBUnexpectedError( $this, 'DatabaseBase::update called with incorrect $conds parameter' );
}

Version: 1.17.x
Severity: minor

Details

Reference: bz27542

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM

• bzimport added a project: MediaWiki-libs-Rdbms.

• bzimport set Reference to bz27542.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Feb 18 2011, 7:10 PM

function update( $table, $values, $conds, $fname = 'DatabaseBase::update', $options = array() ) {

and

function makeList( $a, $mode = LIST_COMMA ) {

Neither of those actually have a default! :)

wmf.amgine3691 wrote:

if( is_null( $cond ) ) echo "default still fails";

Umherirrender updated the task description. (Show Details)Jan 9 2015, 8:45 PM

Umherirrender set Security to None.

Krinkle closed this task as Resolved.Apr 10 2018, 3:32 PM

Krinkle assigned this task to aaron.

Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.

database::update $conds default causes database::makeList failureClosed, ResolvedPublicActions

Description

Details

Event Timeline

database::update $conds default causes database::makeList failure
Closed, ResolvedPublic
Actions