Page MenuHomePhabricator

WikiEditor: Dialogs for inserting links get a few pixel wider every time called
Closed, ResolvedPublic

Description

Whenever a dialog for inserting links, a wider range of the dialog.

  1. Open the Edit page.
  2. Click on the link button in the editing toolbar.
  3. to cancel the dialog that appears.
  4. Repeat 2 and 3.

Then spread the width of each dialog that appears.

In the Japanese Wikipedia, reported the same.

I have confirmed the Japanese version and English version of Wikipedia.
Logging out is the same result.


Version: unspecified
Severity: minor
Platform: PC

Details

Reference
bz27603

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:26 PM
bzimport added projects: WikiEditor, Upstream.
bzimport set Reference to bz27603.
bzimport added a subscriber: Unknown Object (MLST).

Operating environment was confirmed.
OS is WindowsXP.
In IE8 and Google Chrome9 occurred.
But do not occur in Firefox3.6.13.

Reproduced on Safari as well:
Close & reopen the dialogs repeatedly
Width: 505px->510px->515px etc.

I can repro in Chrome on Linux...

Looks like it's happening in the resize function in jquery.wikiEditors.dialogs; there's some scary-looking code in there, but it look like the extra 5 pixels come directly from the wrapper div's .scrollWidth property.

Firefox reports 500, Chrome reports 505. So on Chrome we resize the dialog to 505px, then the next time we re-open it the scrollWidth reports 510, and the cycle continues.

This looks like an upstream webkit bug; may be related to http://code.google.com/p/chromium/issues/detail?id=34224 ...?

(In reply to comment #4)

I can repro in Chrome on Linux...

Looks like it's happening in the resize function in jquery.wikiEditors.dialogs;
there's some scary-looking code in there, but it look like the extra 5 pixels
come directly from the wrapper div's .scrollWidth property.

I wrote that code without any understanding of the box model, so I take full blame :D

This bug is present in WikiEditor master using both Firefox 33.0 and Chromium 37 on Kubuntu 12.04.