Page MenuHomePhabricator

list=blocks: Use ipb_by_text instead of join with user table
Closed, ResolvedPublic

Description

The database field ipb_by_text of the table ipblocks is unused by the api.

The api makes a join with the user table. Looks like old code, because ipb_by_text was added in 1.13, maybe update for better performance?


Version: 1.18.x
Severity: enhancement

Details

Reference
bz27611

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:27 PM
bzimport set Reference to bz27611.

Nice catch. The only downside I can see to this, is we then get "old" names, as the block logs aren't renamed.

ie on en.wiki, I was "Reedy Boy", but now I'm "Reedy".

Not so much of a big deal IMHO

Thanks! r82568

(In reply to comment #1)

The only downside I can see to this, is we then get "old" names, as
the block logs aren't renamed.

Looks like bug 23135

Aye, not a big deal, and would need a cleanup maintenance script

Maybe needs a revert, see bug 31863