Page MenuHomePhabricator

list=logevents: Use log_user_text instead of join with user table
Closed, DeclinedPublic

Description

The database field log_user_text of the table logging is unused by the api.

The api makes a join with the user table. Looks like old code, because
log_user_text was added in 1.16, maybe update for better performance?

The updater has a populate script for log_user_text.


Version: 1.18.x
Severity: enhancement

Details

Reference
bz27614

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:27 PM
bzimport set Reference to bz27614.
bzimport added a subscriber: Unknown Object (MLST).

Looking at the tables running on WMF, old revisions don't have log_user_text, but newer revisions do.

Doing this would require the action of back populating the logging table (populateLogUserText.php)...

It also might require the populateLogSearch.php script running...

Needs a little more research before we can take this one any further

I could almost do this, and then makes the next big deployment blocked on the script being run :P

  • Bug 28754 has been marked as a duplicate of this bug. ***

It *should* JOIN or do a batch lookup, see bug 31863.