Page MenuHomePhabricator

Manual account creation through e-mail results in bad link (French).
Closed, DeclinedPublic

Description

Author: pdeli

Description:
Dear MediaWiki developer team,

For various reasons I am creating manually the accounts of the people who access a wiki on my site. Everything works fine. When I click "par courriel" (via e-mail), the mail is sent to the address of the intended person, however, the latter receives something like this:

QUOTE

Quelqu’un a créé un compte pour votre adresse de courriel sur My Wiki (http://peterdeli.com/uni/wiki/index.php) intitulé « ** », avec le mot de passe « * ».
Vous devriez ouvrir une session et modifier dès à présent votre mot de passe.

Ignorez ce message si ce compte a été créé par erreur.

UNQUOTE

This is not rendered here, but the link is clickable, however, unfortunately, the closing parenthesis is taken into the link thus making the following in the URL field in the default web browser of the user:

http://peterdeli.com/uni/wiki/index.php%29

As you can see, the parenthesis is coded into the link leading to a "404 Not Found".

I am not sure whether the problem persists if the language is changed, however. I haven't tested it yet.

Hoping it helps to improve MediaWiki, I remain,

Yours faithfully,
Peter Deli

++++


Version: 1.16.x
Severity: minor
URL: http://peterdeli.com/uni/wiki/index.php?title=Accueil

Details

Reference
bz27668

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:31 PM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz27668.
bzimport added a subscriber: Unknown Object (MLST).

Which email client do you use?

Note: IIRC we send such emails in plain text, hence the <a> is rendered by the mail user agent. Some implementations might just end the link at the first white space encountered.

Possible way to fix it would be to add an extra space after the URL to prevent bad parsing from the clients.

Created attachment 8201
append a space after URL when sending external mails

Attached patch adds a space after the URL for any messages using the LoginForm::mailPasswordInternal() method.

Attached:

+keywords
Not blocking 1.17 since it is a user side software issue.

pdeli wrote:

Hello Ashar,

E-mail client is web-based and called Sun Convergence (provided by Sun Microsystems). It seems to be written in Java.

I would be very happy to fix the problem myself by adding the required space between the end of the URL and the closing parenthesis if only I knew how...

I didn't find any mention of a possibility of editing the text. I thought it was hardcoded.

Best regards,
Peter Deli

++++

(In reply to comment #1)

Which email client do you use?

Note: IIRC we send such emails in plain text, hence the <a> is rendered by the
mail user agent. Some implementations might just end the link at the first
white space encountered.

Possible way to fix it would be to add an extra space after the URL to prevent
bad parsing from the clients.

Peter,
I have talked about this issue with other developers and, since it is an upstream issue (aka in the mail client), I am not willing to implements a workaround in MediaWiki code (inserting a space).

A workaround is to edit the createaccount-text MediaWiki message and add a space after the field replaced by the url ($4). In your case:

Edit:
http://peterdeli.com/uni/wiki/index.php?title=MediaWiki:Createaccount-text

At:
... adresse de courriel sur My Wiki ($4) intitué ...

Add a space after $4:
... adresse de courriel sur My Wiki ($4 ) intitué ...

Would solve the issue if your users mostly use the Sun Convergence mail client. You, or the user, might want to report the issue to Sun.