Page MenuHomePhabricator

Special:CentralAuth doesn't sort by edit count correctly on other languages
Closed, ResolvedPublic

Description

See e.g. http://commons.wikimedia.org/wiki/Special:CentralAuth/Threecharlie?uselang=it
Edit count is now formatnum'ed, but the table when sorted by edit count actually sorts by first digits group, e.g. 959, 59.592, 7, 5.742 if you use a UI language with a non-English format.


Version: unspecified
Severity: minor

Details

Reference
bz27721

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:23 PM
bzimport set Reference to bz27721.
bzimport added a subscriber: Unknown Object (MLST).

The formatnum should be in content language to match the js var wgSeparatorTransformTable and than the sort script can work right.

We shouldn't compromise on localisation in MediaWiki, formatnum should remain dependent on user language. Instead, the sort script should be adapted to be able to sort according to the language (maybe look at the CSS :lang(xx) value, but I don't know enough JavaScript to know if that is possible).

What about setting the page language to the user language for this special page? Maybe js vars like wgSeparatorTransformTable where added in the user language to the output page and the sort script has the right vars.

All special pages are in the user language, that's not the problem. And the JS var wgSeparatorTransformTable takes $wgContLang->separatorTransformTable(), i.e. of the content language. And we also have wgDigitTransformTable which faces the same issue.

I am going to fix this by changing it from using the [site] content language to the page content language (which is the user language for special pages). This will not fix all cases (e.g. transcluding a special page in an article), but it should be more accurate in most situations.

Done in r104483. That should fix the issue on Special:CentralAuth as well.