Page MenuHomePhabricator
Create Task
Maniphest T29738

ParserTests break when BagOStuff is not able to cache
Closed, DeclinedPublic
Actions

Description

Author: Bryan.TongMinh

Description:
The following ParserTests break:

Running test Bad images - basic functionality... FAILED!
Running test Bad images - bug 16039: text after bad image disappears... FAILED!

But only if BagOStuff::set returns false, indicating that storing in the user cache failed. If BagOStuff::set returns true even if it is not able to store into the cache, the tests pass. If the cache type is CACHE_NONE, the tests pass.

I only tested this with wincache.

(For reference, r78322 introduced the false return value on failure)

Version: unspecified
Severity: enhancement

Details

Reference
bz27738

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:25 PM
• bzimport added a project: MediaWiki-Core-Tests.
• bzimport set Reference to bz27738.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Feb 26 2011, 1:14 PM
Krinkle added a project: MediaWiki-libs-BagOStuff.Aug 25 2016, 8:00 PM
Krinkle set Security to None.
Krinkle added a project: MediaWiki-Parser.
Krinkle edited subscribers, added: aaron, Legoktm; removed: • wikibugs-l-list.
Krinkle closed this task as Declined.Jan 12 2017, 10:07 PM
Krinkle subscribed.

These two "Bad images" tests were disabled in 6bd31e7d95161a6e88fa86df60871051da997c3c.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL