Page MenuHomePhabricator

Save redirects to wrong diff
Closed, ResolvedPublic

Description

Author: a.d.bergi

Description:
I'm not sure whether this bug belongs to the edit process or to diff handling.

I just edited a template, and when I submitted it I got redirected to http://de.wikipedia.org/w/index.php?title=Vorlage:Navigationsleiste_Musik&oldid=85800660&diff=cur&diffonly=0&shownotice=1,
I guess to sight my change. Thats OK, but the diff is strange: the older version shown just is the same as the newer (current) one, the edit comment, the oldid-link: all the same.

I guess the correct link would be without the oldid parameter, or with the oldid parameter set to the previous revision.


Version: unspecified
Severity: normal

Details

Reference
bz27750
ReferenceSource BranchDest BranchAuthorTitle
repos/abstract-wiki/wikifunctions/function-orchestrator!141type-converters-alwaysmainjforresterAlways enable type converters
repos/abstract-wiki/wikifunctions/function-orchestrator!83apine-support-derializersmainapineSupport custom (de)serializers in the orchestrator.
repos/abstract-wiki/wikifunctions/function-orchestrator!81apine-bump-avromainapineAdvance Avro schema version to 0.1.0.
repos/abstract-wiki/wikifunctions/function-orchestrator!80sync-function-schematamainjforresterUpdate function-schemata sub-module to HEAD (a3499c5)
repos/abstract-wiki/wikifunctions/function-evaluator!98sync-function-schematamainjforresterUpdate function-schemata sub-module to HEAD (b392301)
repos/abstract-wiki/wikifunctions/wikilambda-cli!18sync-function-schematamainjforresterUpdate function-schemata sub-module to HEAD (a3499c5)
repos/abstract-wiki/wikifunctions/function-schemata!51apine-feature-flag-derializersmainapineHide the addition of serializers/deserializers behind a feature flag.
repos/abstract-wiki/wikifunctions/function-evaluator!68apine-deserializersmainapineSupport custom derializers in the evaluator/executors.
repos/abstract-wiki/wikifunctions/wikilambda-cli!16sync-function-schematamainjforresterUpdate function-schemata sub-module to HEAD (b5a37af)
repos/abstract-wiki/wikifunctions/function-orchestrator!72sync-function-schematamainapineUpdate function-schemata sub-module to HEAD (b5a37af)
repos/abstract-wiki/wikifunctions/function-evaluator!62sync-function-schematamainapineUpdate function-schemata sub-module to HEAD (b5a37af)
repos/abstract-wiki/wikifunctions/function-schemata!46apine-deserialize-avromainapineAvro semver 0.1.0: support serializers and deserializers in the exchange format.
Show related patches Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport set Reference to bz27750.

I'm going to go with flagged revs fault, since the extension is the thing redirecting you.

So the oldid parameter is for the revision just made?

a.d.bergi wrote:

Exactly. I'm sorry that I didnt' point it out clearly.

Does this occur regularly or randomly?

I can't see how this happens in injectPostEditURLParams()

According to the history, your change was sighted automatically.

(In reply to comment #4)

Does this occur regularly or randomly?

I can't see how this happens in injectPostEditURLParams()

Actually looking at getLatestRevID(), it doesn't handle cache/FOR_UPDATE well...

a.d.bergi wrote:

Please set the fix live, I just got the same error again (http://de.wikipedia.org/w/index.php?title=Vorlage:Infobox_PKW-Modell&oldid=86490550&diff=cur&diffonly=0&shownotice=1).
Might it have something to do with the namespace, I only got these problems after editing a template?

The bug status isn't based on what's live (unless it's a site request).

Also, this fix can't be backported by itself. Other changes and code review are needed. The only thing that could be done is a live-hack, like calling $this->article->getTitle()->resetArticleId(0) before fetching the latest revision to clear the process cache.