http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/Vector.php?view=markup#l360

<li<?php echo $link['attributes'] ?>><span><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo (array_key_exists('img',$link) ?  '<img src="'.$link['img'].'" alt="'.$link['text'].'" />' : htmlspecialchars( $link['text'] ) ) ?></a></span></li>

$link['text']

[22:02:30] -rakkaus:#mediawiki-i18n- (1 lines skipped) [20-Mar-2011 20:01:42] PHP Notice: Undefined index: text in /www/w/skins/Vector.php on line 369

Seems to have moved a line or 2 ;)

Fixed in r84565, 84566.

PHP Notice: Undefined index: href in /www/w/skins/Vector.php on line 369

Should we track where this data comes from?

Yes, I believe it comes from an extension that passes invalid links to Vector.

btw, that's not entirely the same notice as the one this bug was about, so I've widen the summary.

Not sure how much this would break, but perhaps there should be a requirement for which items it needs and otherwise some central (instead of inline) defaults otherwise.

mhershberger wrote:

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

The last issue here seems to be a dupe of 38334. Marking this as resolved fixed (as the primary issue was dealt with).

Bug 38334, that is.