mostly stashing this here so i don't forget.
Http::isValidURI is very lax. For example:
Http::isValidURI('afsddfa fdsa fda fda dehttp://example.com fdfad This is not a url!') == true
even thought thats clearly not a valid uri.
Version: 1.18.x
Severity: enhancement
I have added some tests in r83296
Since we only want to support http,https and ftp protocols; this bug is about implementing the generic syntax of RFC 3986
I made a much improved regex in r83360. It doesn't catch everything you made tests for, but at least acts as a sane sanity check. Making a regex for generic url syntax that checks everything precisely starts to get icky rather fast, especially when considering in what places a colon can appear (seperating username password, the host/port, not to mention ipv6, etc).
I personally think the check in r83360 is sufficient, thoughts?