Page MenuHomePhabricator

add getCallStack() function to mediawiki.log
Closed, InvalidPublic

Description

Author: mdale

Description:
This is helpful for tracing errors when we put in lots of try catch handling that does not show browser native call stacks on global exceptions.


Version: unspecified
Severity: enhancement

Details

Reference
bz27999

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:30 PM
bzimport set Reference to bz27999.
bzimport added a subscriber: Unknown Object (MLST).

mdale wrote:

adds mw.getCallStack to mediaWiki.log

Attached:

mdale wrote:

also mw.getCallStack is helpful for debugging mysterious iOS errors that occur when you hit the device call stack limit of 100 ( other browsers have 1000+ )

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

Michael, do you want to submit this into Git?

This also needs unit tests. And for the follow-up: Check the code conventions (mostly whitespace and a few other details).

mdale wrote:

yea... I don't really use this any more. I generally just comment out the try catch wrappers that hide the native browser callstack when I need to debug such things, and generally know what to look for / avoid in terms of iOS stack overflows

I would instead recommend "debug" / "develop" mode does not use whole resource try catches, but understandable if that deviates too much from non-debug mode. In which case you can just as easy remove the try catches when you need to.

sumanah wrote:

Based on comment #8 I'm closing this issue. Thanks, Michael.