Page MenuHomePhabricator

Add pageCount support to ArchivedFile
Closed, ResolvedPublic

Description

Seems we have requests for this information (yay)... Can we add it?

Want to effectively do ArchivedFile::newFromRow( $row )->pageCount();

Thanks :)


Version: unspecified
Severity: enhancement

Details

Reference
bz28031

Related Objects

StatusSubtypeAssignedTask
ResolvedCatrope
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:32 PM
bzimport set Reference to bz28031.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 8288
Attempt numero uno

Attached:

<Bryan> Reedy: ehh, isn't ArchivedFile::pageCount() just working?
<Bryan> it's inherited from File
<Reedy> Bryan, class ArchivedFile {
<Reedy> It seemed rather strange :/
<Intima> It sure does
<Bryan> wtf

  • Reedy runs away

<Bryan> it can at least inherit File, but possibly LocalFile as well

Leaving as is for the moment... The patch would fix it, but if we're just going to add in a super class, this patch is redundant

Bryan.TongMinh wrote:

(In reply to comment #2)

Leaving as is for the moment... The patch would fix it, but if we're just going
to add in a super class, this patch is redundant

It's good enough for now though.